[Simulation] Remove DAGSimulation - #6261
Conversation
Replace all occurrences of DAGSimulation with Simulation in test files and application examples as part of the removal of the deprecated Sofa.Simulation.Graph package. - Replace new sofa::simulation::graph::DAGSimulation() with new sofa::simulation::Simulation() in all test files - Replace DAGNode with Node in sofaProjectExample - Update SimpleApi to use Simulation instead of DAGSimulation - Remove includes of DAGSimulation.h Remaining work: remove Sofa.Simulation.Graph package and update CMake dependencies.
|
[ci-depends-on] detected during build #5. To unlock the merge button, you must
|
|
[ci-depends-on] detected during build #7. To unlock the merge button, you must
|
|
[ci-depends-on] detected during build #8. To unlock the merge button, you must
|
|
[ci-build][with-scene-tests][with-regression-tests] |
|
[ci-depends-on] detected during build #9. To unlock the merge button, you must
|
|
[ci-depends-on] detected during build #10. To unlock the merge button, you must
|
5b5d721 to
94f5b73
Compare
|
[ci-depends-on] detected during build #11. To unlock the merge button, you must
|
|
[ci-depends-on] detected during build #12. To unlock the merge button, you must
|
|
[ci-depends-on] detected during build #13. To unlock the merge button, you must
|
|
[ci-depends-on] detected during build #19. To unlock the merge button, you must
|
…est (sofa-framework#6267) use EXPECT_DOUBLE_EQ as advised Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
…Matrix (sofa-framework#6268) * use EXPECT_DOUBLE_EQ as advised * increase epsilon in eq testing with zero --------- Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
pixi: Update pixi lockfile Co-authored-by: olivier-roussel <2340432+olivier-roussel@users.noreply.github.com> Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
…hild shared_ptr cycle (sofa-framework#6259) MappingGraph: fix memory leak in from parent/child shared_ptr cycle
* [Playback] Explicit links in ReadState/WriteState * adapt code in CompareState
…-framework#6275) * demonstate that 2x2 and 3x3 selfaliasing invertmatrix are wrong * cache value before using/overwriting them --------- Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
…Field (sofa-framework#6228) * Add potential energy computation for the LinearSmallStrainFEMForceField * Add potential energy for the CorotationalFEMForceField * Use auto * Factor out displacement compute helper
sofa-framework#6256) Fix out-of-bounds matrix writes in MatrixProjectionMethod
9e2b1e9 to
101f2c9
Compare
|
[ci-depends-on] detected during build #20. To unlock the merge button, you must
|
|
[ci-depends-on] detected during build #21. To unlock the merge button, you must
|
|
[ci-depends-on] detected during build #22. To unlock the merge button, you must
|
| }; | ||
|
|
||
| /// Singleton oriented API, if needed. | ||
| class SOFA_SIMULATION_CORE_API MainSimulation |
There was a problem hiding this comment.
Just a remark, we previously said that one file = one class (with both the same name)
alxbilger
left a comment
There was a problem hiding this comment.
Do you agree that in the future we can get rid of the Simulation class?
Well, I have no special desire to keep it, so I assume this is a yes And to @hugtalbot yes, given that Simulation and thus MainSimulation should be removed at some point do you want me to do such a thing (as this will imply to change most of the #include<xxx/simulation.h> to #include<xxx/MainSimulation.h> |
|
Since the idea is to possibly go towards the removal of the singleton, the rule (one file = one class) might not apply 👍 Thanks for your work @damienmarchal |
|
CI seems to fail I just rebased |
|
[ci-depends-on] detected during build #23. To unlock the merge button, you must
|
Replace all occurrences of DAGSimulation with Simulation in test files and application examples as part of the removal of the deprecated Sofa.Simulation.Graph package.
new sofa::simulation::Simulation() in all test files
Remaining work: remove Sofa.Simulation.Graph package and update CMake dependencies.
[ci-depends-on https://github.com/sofa-framework/SofaGLFW/pull/296]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/635]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/239]
[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/181]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/352]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots.Inverse/pull/90]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if