Skip to content

[Simulation] Remove DAGSimulation - #6261

Open
damienmarchal wants to merge 22 commits into
sofa-framework:masterfrom
CRIStAL-PADR:pr-remove-dagsimulation
Open

[Simulation] Remove DAGSimulation#6261
damienmarchal wants to merge 22 commits into
sofa-framework:masterfrom
CRIStAL-PADR:pr-remove-dagsimulation

Conversation

@damienmarchal

@damienmarchal damienmarchal commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Replace all occurrences of DAGSimulation with Simulation in test files and application examples as part of the removal of the deprecated Sofa.Simulation.Graph package.

  • Replace new sofa::simulation::graph::DAGSimulation() with
    new sofa::simulation::Simulation() in all test files
  • Replace DAGNode with Node in sofaProjectExample
  • Update SimpleApi to use Simulation instead of DAGSimulation
  • Remove includes of DAGSimulation.h

Remaining work: remove Sofa.Simulation.Graph package and update CMake dependencies.

[ci-depends-on https://github.com/sofa-framework/SofaGLFW/pull/296]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/635]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/239]
[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/181]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/352]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots.Inverse/pull/90]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@damienmarchal damienmarchal added pr: breaking Change possibly inducing a compilation error pr: refactoring Refactor code labels Aug 25, 2026
Comment thread Sofa/framework/Simulation/Graph/src/sofa/simulation/graph/DAGSimulation.h Outdated
@alxbilger alxbilger changed the title Remove DAGSimulation [Simulation] Remove DAGSimulation Aug 26, 2026
Replace all occurrences of DAGSimulation with Simulation in test files
and application examples as part of the removal of the deprecated
Sofa.Simulation.Graph package.

- Replace new sofa::simulation::graph::DAGSimulation() with
  new sofa::simulation::Simulation() in all test files
- Replace DAGNode with Node in sofaProjectExample
- Update SimpleApi to use Simulation instead of DAGSimulation
- Remove includes of DAGSimulation.h

Remaining work: remove Sofa.Simulation.Graph package and update CMake dependencies.
@sofabot

sofabot commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #5.

To unlock the merge button, you must

@sofabot

sofabot commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #7.

To unlock the merge button, you must

@sofabot

sofabot commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #8.

To unlock the merge button, you must

@damienmarchal

Copy link
Copy Markdown
Contributor Author

[ci-build][with-scene-tests][with-regression-tests]

@sofabot

sofabot commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #9.

To unlock the merge button, you must

@sofabot

sofabot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #10.

To unlock the merge button, you must

@damienmarchal
damienmarchal force-pushed the pr-remove-dagsimulation branch from 5b5d721 to 94f5b73 Compare August 27, 2026 12:56
@sofabot

sofabot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #11.

To unlock the merge button, you must

@sofabot

sofabot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #12.

To unlock the merge button, you must

@sofabot

sofabot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #13.

To unlock the merge button, you must

@sofabot

sofabot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #19.

To unlock the merge button, you must

fredroy and others added 10 commits September 9, 2026 11:29
…est (sofa-framework#6267)

use EXPECT_DOUBLE_EQ as advised

Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
…Matrix (sofa-framework#6268)

* use EXPECT_DOUBLE_EQ as advised

* increase epsilon in eq testing with zero

---------

Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
pixi: Update pixi lockfile

Co-authored-by: olivier-roussel <2340432+olivier-roussel@users.noreply.github.com>
Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
…hild shared_ptr cycle (sofa-framework#6259)

MappingGraph: fix memory leak in from parent/child shared_ptr cycle
* [Playback] Explicit links in ReadState/WriteState

* adapt code in CompareState
…-framework#6275)

* demonstate that 2x2 and 3x3 selfaliasing invertmatrix are wrong

* cache value before using/overwriting them

---------

Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
…Field (sofa-framework#6228)

* Add potential energy computation for the LinearSmallStrainFEMForceField

* Add potential energy for the CorotationalFEMForceField

* Use auto

* Factor out displacement compute helper
@damienmarchal
damienmarchal force-pushed the pr-remove-dagsimulation branch from 9e2b1e9 to 101f2c9 Compare September 9, 2026 09:30
@sofabot

sofabot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #20.

To unlock the merge button, you must

@damienmarchal damienmarchal added the pr: status to review To notify reviewers to review this pull-request label Sep 9, 2026
@sofabot

sofabot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #21.

To unlock the merge button, you must

@sofabot

sofabot commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #22.

To unlock the merge button, you must

};

/// Singleton oriented API, if needed.
class SOFA_SIMULATION_CORE_API MainSimulation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a remark, we previously said that one file = one class (with both the same name)

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 10, 2026

@alxbilger alxbilger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you agree that in the future we can get rid of the Simulation class?

@damienmarchal

damienmarchal commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Do you agree that in the future we can get rid of the Simulation class?

Well, I have no special desire to keep it, so I assume this is a yes

And to @hugtalbot yes, given that Simulation and thus MainSimulation should be removed at some point do you want me to do such a thing (as this will imply to change most of the #include<xxx/simulation.h> to #include<xxx/MainSimulation.h>

@hugtalbot

Copy link
Copy Markdown
Contributor

Since the idea is to possibly go towards the removal of the singleton, the rule (one file = one class) might not apply 👍
We set the PR as ready this morning

Thanks for your work @damienmarchal

@hugtalbot

Copy link
Copy Markdown
Contributor

CI seems to fail I just rebased

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request and removed pr: status ready Approved a pull-request, ready to be squashed labels Sep 10, 2026
@sofabot

sofabot commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #23.

To unlock the merge button, you must

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: breaking Change possibly inducing a compilation error pr: refactoring Refactor code pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants